Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not clone Mir unnecessarily #37489

Merged
merged 1 commit into from
Oct 31, 2016
Merged

Do not clone Mir unnecessarily #37489

merged 1 commit into from
Oct 31, 2016
+7 −5

Conversation

nagisa
Copy link
Member

@nagisa nagisa commented Oct 31, 2016

r? @eddyb

@eddyb
Copy link
Member

eddyb commented Oct 31, 2016

@bors r+

@bors
Copy link
Contributor

bors commented Oct 31, 2016

📌 Commit 8ec0b3a has been approved by eddyb

@eddyb
Copy link
Member

eddyb commented Oct 31, 2016

@bors p=7 This fixes a perf regression.

@nnethercote
Copy link
Contributor

For the record: #37400 was the PR that introduced the regression.

@bors
Copy link
Contributor

bors commented Oct 31, 2016

⌛ Testing commit 8ec0b3a with merge 8f1fc86...

bors added a commit that referenced this pull request Oct 31, 2016
@bors
Auto merge of #37489 - nagisa:unnecessary-clone, r=eddyb
8f1fc86 
Do not clone Mir unnecessarily

r? @eddyb
@bors
Copy link
Contributor

bors commented Oct 31, 2016

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-rustbuild
Approved by: eddyb
Pushing 8f1fc86 to master...

@bors bors merged commit 8ec0b3a into rust-lang:master Oct 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@eddyb eddyb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nagisa @eddyb @bors @nnethercote